The parameter external_sources in both the definition of the check command as well as the check job is ignored and the flag --external-sources is not passed to shellcheck.
Even though the option is defined here, the job 13094 (shellcheck/check) fails with the error message:
source "$(dirname "${BASH_SOURCE[0]}")/_functions.sh"
^-- SC1091: Not following: ./dev-tools/_functions.sh was not specified as input (see shellcheck -x).
Expected behavior:
I expect the external_sources parameter in the workflow definition to be passed to shellcheck via the --external-sources flag.
Additional Information:
Digging deeper into the issue, I copied the orb code into my own CircleCI config and added a little bit of diagnostic output:
So I assume that boolean parameters are being converted to their int representation when they're passed to a command via the environment (testing the same with false set $SC_PARAM_EXTERNAL_SOURCES to 0.
Looking at the docs, the recommended way of using boolean parameters for flags seems to be:
Orb version: 2.2.2
What happened:
The parameter
external_sources
in both the definition of the check command as well as the check job is ignored and the flag--external-sources
is not passed to shellcheck. Even though the option is defined here, the job 13094 (shellcheck/check) fails with the error message:Expected behavior:
I expect the
external_sources
parameter in the workflow definition to be passed to shellcheck via the--external-sources
flag.Additional Information:
Digging deeper into the issue, I copied the orb code into my own CircleCI config and added a little bit of diagnostic output:
which outputs (see job 13098):
So I assume that boolean parameters are being converted to their int representation when they're passed to a command via the environment (testing the same with
false
set$SC_PARAM_EXTERNAL_SOURCES
to0
.Looking at the docs, the recommended way of using boolean parameters for flags seems to be:
But I'm not sure if this works if the script is being included.