search

CircleCI-Public / shellcheck-orb

An orb for ShellCheck, a static analysis tool for shell scripts (https://shellcheck.net) — check all scripts in your repository on every commit
https://circleci.com/developer/orbs/orb/circleci/shellcheck
MIT License
19 stars 26 forks source link

fix: exit 1 when shellcheck is not installed #53

Closed gcagle3 closed 2 years ago

gcagle3 commented 2 years ago

Running this Orb with a custom image that doesn't have shellcheck installed will result in the workflow returning "Shellcheck not installed" with a success exit code, which will prevent shellcheck from catching potential issues. This PR changes the exit status to 1 so that the job will fail if shellcheck is not installed (and therefore not ran).

gcagle3 commented 2 years ago

Looks like the tests failed for SC2295 (also seeing SC2148 potentially causing issues) against the original code. Just pushed a minor change to address these as well.

EricRibeiro commented 2 years ago

The xcode version used for the tests isn't valid anymore. Would you mind changing it to 13.4.1?

Reference: https://github.com/CircleCI-Public/shellcheck-orb/blob/master/.circleci/test-deploy.yml#L61

gcagle3 commented 2 years ago

The xcode version used for the tests isn't valid anymore. Would you mind changing it to 13.4.1?

Reference: https://github.com/CircleCI-Public/shellcheck-orb/blob/master/.circleci/test-deploy.yml#L61

No problem, updated!

orb-publisher commented 2 years ago

Your orb has been published to the CircleCI Orb Registry. You can view your published orb on the CircleCI Orb Registry at the following link: https://circleci.com/developer/orbs/orb/circleci/shellcheck?version=3.1.2