CircleCI-Public / shellcheck-orb

An orb for ShellCheck, a static analysis tool for shell scripts (https://shellcheck.net) — check all scripts in your repository on every commit
https://circleci.com/developer/orbs/orb/circleci/shellcheck
MIT License
19 stars 26 forks source link

[semver:minor] Add circleci ip range options #59

Closed nanophate closed 1 year ago

nanophate commented 1 year ago

Changes

Customer reported that when they have their GitHub managed allowed IP enabled they can not checkout using the orb tools. To mitigate this issue I added the circleci_ip_ranges options.

Managing allowed IP addresses for your organization: You can restrict access to your organization's private assets by configuring a list of IP addresses that are allowed to connect.

Additional note

I thought of creating an executor that enables this but it looks like circleci_ip_ranges are not supported. There fore I gave up on creating an executor and created a pr to directly address this issue.

Screenshot 2023-07-18 at 15 08 25

https://github.com/CircleCI-Public/orb-tools-orb/pull/218

nanophate commented 1 year ago

Seems like there is an limitation and need more work to mitigate this issue.

There is currently no support for specifying IP ranges configuration syntax when using the pipeline parameters feature. Find more details in this Discuss post