CircleCI-Public / slack-orb

Create custom Slack notifications for CircleCI job statuses
https://circleci.com/developer/orbs/orb/circleci/slack
MIT License
212 stars 205 forks source link

ci: migrate to Orb Tools 12 #407

Closed EricRibeiro closed 1 year ago

EricRibeiro commented 1 year ago

Description

This PR updates the Slack Orb to the new major version of Orb Tools. As it contains breaking changes, several modifications were unnecessary to move from v11 to v12.

Changes

The comprehensive list of changes can be found below.

Changes in .circleci/config.yml:

  1. Update the orb-tools version from 11.4 to 12.0.
  2. Move the job requirement list from orb-tools/publish to orb-tools/continue.
  3. Remove the orb-tools/publish job since development versions are no longer necessary.
  4. Add the new orb_name parameter in orb-tools/continue.
  5. Rename the orb-tools/continue job parameters to comply with the new snake case standard.
    • orb_name, pipeline_number and vcs_type.

Changes in .circleci/test-deploy.yml:

  1. Update the orb-tools version from 11.4 to 12.0.

  2. Remove the slack: circleci/slack@dev:<<pipeline.git.revision>> line, and replace it with slack: {}.

  3. Remove the orb-tools/lint and orb-tools/review jobs. ⚠️

  4. Rename the orb-tools/publish job parameters to comply with the new snake case standard.

    • orb_name, vcs_type, pub_type, enable_pr_comment and github_token.
  5. Change the orb-tools/pack filter to trigger only on tagged releases.

    Changes in src/examples/full_deployment_sample.yml:

  6. Replace slack/on-hold with slack/on_hold to comply with the new snake case standard.

    Changes in src/examples/on_hold_notification.yml:

  7. Replace slack/on-hold with slack/on_hold to comply with the new snake case standard.


⚠️: This change is not related to the migration itself. These jobs were redundant in test-deploy.yml as they already run in config.yml. See Orb-Template #2.

orb-publisher commented 1 year ago

Your development orb(s) have been published. It will expire in 30 days. You can preview what this will look like on the CircleCI Orb Registry at the following link: https://circleci.com/developer/orbs/orb/?version=dev:dev:${CIRCLE_SHA1}

orb-publisher commented 1 year ago

Your development orb(s) have been published. It will expire in 30 days. You can preview what this will look like on the CircleCI Orb Registry at the following link: https://circleci.com/developer/orbs/orb/?version=dev:dev:${CIRCLE_SHA1}

KyleTryon commented 1 year ago

I believe RC010 should have failed unless ignored. Looking into this.

KyleTryon commented 1 year ago

I believe RC010 should have failed unless ignored. Looking into this.

I was wrong, I assumed we would have failed RC010, turns out this orb was already up-to-code on that.