search

CircleCI-Public / slack-orb

Create custom Slack notifications for CircleCI job statuses
https://circleci.com/developer/orbs/orb/circleci/slack
MIT License
212 stars 205 forks source link

fix: add removal of carriage return during sanitization #411

Open alexcheuk opened 1 year ago

alexcheuk commented 1 year ago

Description

This pull request fixes the issue where variables used within a custom template contain CRLF-style new lines (ie \r\n).

A fix and test are added to test against this using a file with multiline content set to use CRLF for line endings.

A production use case for this issue is when one wants to send a Slack notification with a multiline commit message from GitHub. If the message was fetched using git show --pretty=format:%B --no-patch, the new lines uses \r\n.