search

CircleCI-Public / slack-orb

Create custom Slack notifications for CircleCI job statuses
https://circleci.com/developer/orbs/orb/circleci/slack
MIT License
212 stars 205 forks source link

fix: `thread_id` cache should work for all event types #449

Closed jasonyoung-pearl closed 1 month ago

jasonyoung-pearl commented 2 months ago

Right now, if the event type is fail, the thread_id will be ignored because the save_cache and restore_cache steps do not have when set, meaning they default to on_success and do not run.

This PR changes the cache steps so that they always run (on the condition that thread_id is being set, anyway).

geoL86 commented 1 month ago

The same behavior for me as well ... already voted

geoL86 commented 1 month ago

Hey @tremblay @aaronstillwell, guys, who has power to check and approve these changes? Look like there are not so much and will help that's for sure ...

tremblay commented 1 month ago

Hey @tremblay @aaronstillwell, guys, how has power to check and approve these changes? Look like there are not so much and will help that's for sure ...

not sure why you tagged me, I am not a contributor to this project in any way

otremblay commented 1 month ago

I'm the correct "tremblay" to tag on these, let me take a peek and see what I can do

orb-publisher commented 1 month ago

Your orb has been published to the CircleCI Orb Registry. You can view your published orb on the CircleCI Orb Registry at the following link: https://circleci.com/developer/orbs/orb/circleci/slack?version=4.13.3