Changing SLACK_WEBHOOK parameter type to env_var_name

CircleCI-Public / slack-orb

Create custom Slack notifications for CircleCI job statuses

https://circleci.com/developer/orbs/orb/circleci/slack

MIT License

214 stars 206 forks source link

Changing SLACK_WEBHOOK parameter type to env_var_name #79

Closed pbaderia01 closed 3 years ago

pbaderia01 commented 4 years ago

Orb version

8.7.23

What happened

We should consider changing the data type of slack webhook to env_var_name since the variable does not require user input once set and would be easy to manage using CircleCI env vars. Also this follows the best practices for orbs.

https://circleci.com/docs/2.0/orbs-best-practices/#parameters

pbaderia01 commented 4 years ago

Hi, I would also like to pick this up. Please consider adding the orbtoberfest label on the issue.