CircleCI-Public / terraform-orb

Deploy your infrastructure via a CircleCI pipeline using the Terraform orb. Integrate Infrastructure-as-Code (IaC) to help provision and manage any cloud, infrastructure, or service of your choice.
https://circleci.com/orbs/registry/orb/circleci/terraform
MIT License
10 stars 44 forks source link

feat: lock param on terraform plan (default to true) #106

Closed VincentPerez closed 1 month ago

VincentPerez commented 5 months ago

Adding lock param on terraform plan (default to true)

I filed an issure here : https://github.com/CircleCI-Public/terraform-orb/issues/105

henrahmagix commented 1 month ago

@KyleTryon is it possible please to implement this PR? Currently, having terraform/plan run in every branch so we can review the output, makes any existing plan that's waiting to be applied stale, so it breaks our merging and applying flow. Being able to set -lock=false on PR branches would be extremely helpful ☺️

The changes seem to be correct to me =)

KyleTryon commented 1 month ago

@KyleTryon is it possible please to implement this PR? Currently, having terraform/plan run in every branch so we can review the output, makes any existing plan that's waiting to be applied stale, so it breaks our merging and applying flow. Being able to set -lock=false on PR branches would be extremely helpful ☺️

The changes seem to be correct to me =)

Sorry. I am no longer a part of this organization.

orb-publisher commented 1 month ago

Your development orb has been published. It will expire in 30 days. You can preview what this will look like on the CircleCI Orb Registry at the following link: https://circleci.com/developer/orbs/orb/circleci/terraform?version=dev:daab6602bd753b523e83d07a13580628daab1486

orb-publisher commented 1 month ago

Your development orb has been published. It will expire in 30 days. You can preview what this will look like on the CircleCI Orb Registry at the following link: https://circleci.com/developer/orbs/orb/circleci/terraform?version=dev:8bb0ba44036b593990635ef08a2f629976ca04ed

orb-publisher commented 1 month ago

Your development orb has been published. It will expire in 30 days. You can preview what this will look like on the CircleCI Orb Registry at the following link: https://circleci.com/developer/orbs/orb/circleci/terraform?version=dev:ef3478be3aa4b1d7e13c08ed91b067ea3c05b549

henrahmagix commented 1 month ago

Thanks so much @marboledacci!