search

CircleCI-Public / terraform-orb

Deploy your infrastructure via a CircleCI pipeline using the Terraform orb. Integrate Infrastructure-as-Code (IaC) to help provision and manage any cloud, infrastructure, or service of your choice.
https://circleci.com/orbs/registry/orb/circleci/terraform
MIT License
10 stars 44 forks source link

feat: add resource_class parameter for docker executor #60

Closed kynefuk closed 2 years ago

kynefuk commented 2 years ago

Add resource_class parameters for docker executor.

According to the official documentation, if you do not specify a size, resource_class will be set automatically.

For new projects created after September 1, 2021 that do not specify a resource class, CircleCI will try to find the right default value for your organization. To avoid using a default, explicitly specify a resource class size in your config for each job. https://circleci.com/docs/2.0/configuration-reference/#resourceclass

I want to add an option so that I can select resource_class size.

KyleTryon commented 2 years ago

Hello @kynefuk Apologies for the day. I would like you add your change but I believe it may be best to use a generic string rather than an enum in this case, so that there is the potential for users of CircleCI Runner to specify their resource class as well. As this branch is now out of date as well (on us, sorry about that), I will take it on to re-incorporate your change in a new PR if that is alright with you.

I will close this PR for now, if you would like to collaborate on the new changes please feel free to let me know. I expect we'll see these changes live in about 2 weeks max.

kynefuk commented 2 years ago

@KyleTryon Thanks! I'll make a new PR based on your comments!