search

CircleCI-Public / terraform-orb

Deploy your infrastructure via a CircleCI pipeline using the Terraform orb. Integrate Infrastructure-as-Code (IaC) to help provision and manage any cloud, infrastructure, or service of your choice.
https://circleci.com/orbs/registry/orb/circleci/terraform
MIT License
10 stars 44 forks source link

apply does not seem to read in plan file #63

Closed naseemkullah closed 2 years ago

naseemkullah commented 2 years ago

The usage examples seem to suggest that the plan file is passed through via attaching a workspace between plan and apply jobs but I don't see how it works:

https://github.com/CircleCI-Public/terraform-orb/blob/0d0e0587128d868e0f10443b35d0381db358ae9c/src/scripts/apply.sh#L66

does not read in the plan file (plan.out) from https://github.com/CircleCI-Public/terraform-orb/blob/0d0e0587128d868e0f10443b35d0381db358ae9c/src/scripts/plan.sh#L69

KyleTryon commented 2 years ago

Hello @naseemkullah. I have opened a PR #74 which should have a backwards compatible change. If you are able, I'd love your feedback. The orb can also be tested here:

You can preview what this will look like on the CircleCI Orb Registry at the following link: https://circleci.com/developer/orbs/orb/circleci/terraform?version=dev:0cadaa0d00d2b4b54dd67f498057802e9c327329

KyleTryon commented 2 years ago

Terraform Orb 3.1.0 is live: https://github.com/CircleCI-Public/terraform-orb/releases/tag/v3.1.0 Please try the latest version of the orb and let us know what you think!

Version 4.0.0 progress will begin soon with improved support for Terraform cloud and some new sensible defaults.