CircleCI-Public / trigger-circleci-pipeline-action

Trigger a CircleCI pipeline from any GitHub Actions event.
https://github.com/marketplace/actions/trigger-circleci-pipeline
48 stars 43 forks source link

build(hooks): add the transcompiled files in dist/ to the pre-commit hook #46

Closed whatisdot closed 1 year ago

whatisdot commented 1 year ago

Currently

The pre-commit hook transcompiles the ECMA scripts into JavaScript, but doesn't add it while the commit is in progress. I can't find any documentation or conversation about this, so it's unclear if this was intentional.

Problem

This requires us to create an additional commit after our source-commit to include the build.

Solution

Modify the pre-commit hook to add the transcompiled code to the commit that is in progress.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

more details

What issues are resolved by this PR?

Describe the new behavior.

When committing source changes, the build will now be included automatically by the pre-commit hook.

Does this PR introduce a breaking change?

whatisdot commented 1 year ago

The process described in #45 outlines a build process separate from PR branch commits. That, combined with the linter/fixer behavior that @paikattilrohin mentioned, suggest that more discussion is needed before auto-committing changes on behalf of a developer.