CircleOfNice / CiRestClientBundle

Mapper for PHP internal curl library

GNU General Public License v3.0

57 stars 20 forks source link

Fill the Symfony Response with real responded headers #32

Closed Timo-Linde closed 8 years ago

Timo-Linde commented 8 years ago

33 Automatically map response headers

TobiasHauck commented 8 years ago

Thank you for opening the PR and sorry for responding so late!

TobiasHauck commented 8 years ago

Just cloned your branch to check the code coverage. make test errored: $content = substr($curlResponse, $headerSize); returns FALSE if the header size is equal to strlen. So what you need to add is $content = empty($content) ? '' : $content;

TobiasHauck commented 8 years ago

May you be so kind and add my suggestions? I think after these changes we can merge the PR. If you give me your email address I will add you to the AUTORS file ;) Thanks again!

Timo-Linde commented 8 years ago

Can you merge this PR and tag a new version? I need this code for 3 productive applications.

Timo-Linde commented 8 years ago

Thank you very much. Keep up the great work. = )

TobiasHauck commented 8 years ago

Thank you for contributing! I'll add you to the AUTHORS file very soon!