Review

[passi246]

CiRestClientBundle/resources/config/services.yml

• [ ] Use class parameters consistently

CiRestClientBundle/Services/RestClient.php

• [ ] Reduce api (setContentType ), if not necessary

CiRestClientBundle/DependencyInjection/CircleRestClientExtension.php

• [ ] Redesign (config creation)

CiRestClientBundle/Exceptions/*Exception.php

• [ ] Rework Exceptions

CiRestClientBundle/Parsers/HTTPHeadersParser.php

• [ ] Rework

CiRestClientBundle/Tests

• [ ] Rename Unit to Functional
• [ ] Remove Bootstrap.php~ (+ gitignore)

CiRestClientBundle/Tests/Unit/RestClientTest.php

• [ ] L55 "=" indent

CiRestClientBundle/Tests/Functional/Parsers/HTTPHeadersParserTest.php

• [ ] L83 "=" indent

CiRestClientBundle/Tests/Functional/Services/CurlTest.php

• [ ] https://github.com/CircleOfNice/CiRestClientBundle/blob/master/Tests/Functional/Services/CurlTest.php#L53 "=" indent

Circle/RestClientBundle/Traits/Assertions.php

• [ ] Assertions should assert :D