A tree builder without a root node is deprecated since Symfony 4.2 and will not be supported anymore in 5.0

CircleOfNice / CiRestClientBundle

Mapper for PHP internal curl library

GNU General Public License v3.0

57 stars 20 forks source link

A tree builder without a root node is deprecated since Symfony 4.2 and will not be supported anymore in 5.0 #51

Open dsands opened 5 years ago

dsands commented 5 years ago

{▼ /Users/david/Projects/axis/vendor/symfony/config/Definition/Builder/TreeBuilder.php:30 {▶} /Users/david/Projects/axis/vendor/ci/restclientbundle/Circle/RestClientBundle/DependencyInjection/Configuration.php:39 {▼ › { › $treeBuilder = new TreeBuilder(); › $rootNode = $treeBuilder->root('circle_rest_client'); } }

dsands commented 5 years ago

Seems to fix and maintain backward compatibility:

// $treeBuilder = new TreeBuilder(); // $rootNode = $treeBuilder->root('circle_rest_client'); if (method_exists(TreeBuilder::class, 'getRootNode')) { $treeBuilder = new TreeBuilder('circle_rest_client'); $rootNode = $treeBuilder->getRootNode(); } else { $treeBuilder = new TreeBuilder(); $rootNode = $treeBuilder->root('circle_rest_client'); }