CircleOfNice / DoctrineRestDriver

GNU General Public License v3.0

153 stars 44 forks source link

Add query limit as http header #13

Closed djaney closed 8 years ago

djaney commented 8 years ago

16 Pagination

17 Ordering

Proposed Changes

Add limit query as http header called Query-Limit and Query-Offset
Add order by query as http header called Query-Order

TobiasHauck commented 8 years ago

Hi Djane thanks for opening the PR! You're absolutely right: We are missing pagination information as well as ordering information and the headers are the right place to add them. Maybe we should rename Query-Limit to Limit, Query-Offset to Offset and Query-Order to Order.

Would you also be so kind to add the missing tests for the new feature? Thank you for contributing!

TobiasHauck commented 8 years ago

Ok if you have changed all my suggestions this one is ready to merge - thanks a lot, you did a great job!

TobiasHauck commented 8 years ago

Just checked the code coverage to merge the PR and realized it was not 100% ... 😢 This is when I found these last errors :D

TobiasHauck commented 8 years ago

Well if you like to you choose the next release title. It has to be related to the TV series house of cards.

djaney commented 8 years ago

I added the coverage annotations. My coverage is not working so I don't know if there are more

TobiasHauck commented 8 years ago

That's all. Coverage is at 100% again. So please update the comments and we are ready. What about the release name?

djaney commented 8 years ago

I'm not really on the house of cards. Does "The Washington Herald" sound ok?

TobiasHauck commented 8 years ago

yes great, let's call it "The Washington Herald"