HTTP PATCH support - Githubissues

CircleOfNice / DoctrineRestDriver

GNU General Public License v3.0

153 stars 44 forks source link

HTTP PATCH support #57

Closed robwasripped closed 7 years ago

robwasripped commented 7 years ago

Fixes #54

Proposed Changes

Added PATCH capability to to driver
Added option to toggle PATCH over PUT in driver options

TobiasHauck commented 7 years ago

You did an awesome job, thank you for this PR! One of the best PRs I've ever checked. I'd be a pleasure if you helped me in future with some more challenging issues :-)

TobiasHauck commented 7 years ago

This is worth a new minor version. May you please update the composer.json from 1.0 to 1.1 ? Afterwards I will merge the PR and release the new version

robwasripped commented 7 years ago

Version has been bumped. :)

TobiasHauck commented 7 years ago

Ok great. So last step (I forgot that yesterday) is to update the README.md . Otherwise nobody will know that this feature exists. Would you mind to update the README ? Just a few words about the new functionality

TobiasHauck commented 7 years ago

Regarding the readme we should probably send the whole entity if PUT is used... :-D But that's another issue

robwasripped commented 7 years ago

It would be great to be able to send the whole entity in a PUT but I'm not sure we can get that information out of Doctrine. It's worth looking into though.

TobiasHauck commented 7 years ago

Ok let's create an issue for that. Just to check if it's possible