search

CircleTree / enom_pro

eNom PRO for WHMCS
https://mycircletree.com/products/enom-pro-whmcs-addon/
10 stars 11 forks source link

getDomainsWithClients( true, 1) does not return a subset of imported clients returned by getDomainsWithClients( true, 1, 'imported') #44

Closed bobbravo2 closed 9 years ago

bobbravo2 commented 9 years ago

Test case already written: test_get_domains_show_all()

Steps to reproduce problem - See test case for details

Please spend up to 1 hour billable - also I'd appreciate any constructive code quality improvements you can make as well, as well as writing more tests to help cover cases like this. I'd ultimately like to refactor big complicated methods :-1: like this one, getDomainsWithClients() to a more modular, testable interface. Please take some time looking at how you'd suggest we improve the code, and priority one is getting this failing test passing this is a blocker for the 3.0 release.

bobbravo2 commented 9 years ago

to ensure test consistency between environments: Updated database schema pushed in #1fac8c3