CirclesUBI / circles-contracts

Fully automated luxury gay space communism contracts
GNU Affero General Public License v3.0
73 stars 22 forks source link

Give personal currency sensible names / allow users to personalize the name on creation #12

Closed Jake-Gillberg closed 5 years ago

edzillion commented 6 years ago

I have thought about this before:

ana0 commented 6 years ago

We would need some kind of oversight to make sure people didn't make offensive named coins. How easily could this be automated?

Offensive I wouldn't worry about, but we should sanitize for code-injection: https://hackernoon.com/how-one-hacker-stole-thousands-of-dollars-worth-of-cryptocurrency-with-a-classic-code-injection-a3aba5d2bff0

ana0 commented 5 years ago

Recycling this issue, because it seems related ..

ERC20 has three standard 'informational' variables - name, symbol, and decimals. These are primarily used by wallets and sites like etherscan for display. Would be great if our tokens are displayed properly in as many uis as possible.

For name, I'm thinking the user should probably be able to set their own name. For decimals, it seems a system-wide (or at least hub-wide) number is the only real path (the community has been coalescing around 18). Jury is out for me on symbol - thinking this could be user set, but also could be a system-wide, like all circles tokens display as CRC or something.

And of course the final question, which is if we go with a system wide symbol, what should it be?

JuliointheStudio commented 5 years ago

hello! can you give me an example of how symbols look like? I agree that people should be able to set their own name.. the decimal thing I have no clue about but the symbol seems to be important.. :)

edzillion commented 5 years ago

Probably decimal is to set which kind of decimal marker you want. (in US/UK it's . and in EU it tends to be ,)

Symbol is probably an ascii code. I vote for ©

ana0 commented 5 years ago

Decimals is a weird software thing, because the evm doesn't have good support for floating point numbers. Numbers are stored as integers based on their least significant digit. So like, for 20.00 USD, the evm would store 2000 and decimals = 2. For ether, it's 18. Most tokens use 18 too. It's kind of technical thing, not something users need to think about.

Symbol is like a ticker symbol, like 'USD' or 'ETH'.

edzillion commented 5 years ago

Symbol is like a ticker symbol, like 'USD' or 'ETH'.

hmmm. Seems like CRC isn't taken, at least according to wikipedia (which is kinda cool cos it also means Capablanca Random Chess)

https://en.wikipedia.org/wiki/List_of_cryptocurrencies

ana0 commented 5 years ago

Ok, gonna go with CRC for now