CirclesUBI / circles-contracts

Fully automated luxury gay space communism contracts
GNU Affero General Public License v3.0
73 stars 22 forks source link

Enable compatibility with safe-contracts 1.3.0 #166

Closed llunaCreixent closed 2 years ago

llunaCreixent commented 2 years ago

We add the support of the last version of the safe-contracts.

Tasks:

Acceptance criteria:

Closes https://github.com/CirclesUBI/circles-contracts/issues/165

llunaCreixent commented 2 years ago

We have to change the import of the safe-contracts in circles-contracts/migrations/3_deploy_safe.js

mikozet commented 2 years ago

Screenshot from 2022-11-21 08-57-44 Screenshot from 2022-11-21 08-55-41 Screenshot from 2022-11-21 08-54-55

Tests don't pass for me but maybe it is some unrelated problem. I tried using node v14.21.1 npm 6.14.17

llunaCreixent commented 2 years ago

@mikozet for the core tests you need to work with the use-latest-contracts branch of docker. And remember to cp .env.example .env, also do it in the core branch

mikozet commented 2 years ago

@mikozet for the core tests you need to work with the use-latest-contracts branch of docker. And remember to cp .env.example .env, also do it in the core branch

Thx @llunaCreixent I will write it down but also was thinking maybe we should include that info somewhere? Like Internal Handbook?