CirclesUBI / circles-groups-safe-app

[DEPRECATED] Mint Circles group tokens using this Safe app
https://groups.circlesubi.dev/
1 stars 1 forks source link

Bug/#139 mint uses max flow instead of input #146

Closed LaimeJesus closed 2 years ago

LaimeJesus commented 2 years ago

related #139 #144

Description

This PR fixes the issue when user mints an amount it uses the maximum available amount instead of the input amount, it adds the following changes:

Fixes

Updates

How To Test

See steps

There are logs to see the different parameters used to mint, just for debugging purposes.

Example tx: https://blockscout.com/xdai/mainnet/tx/0x575d3ffcba3e6683fb0d1cb19dc19076bd58d4e7a99fdd00663a8a3abade1f25

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
circles-groups-safe-app ✅ Ready (Inspect) Visit Preview Jul 28, 2022 at 6:27PM (UTC)
LaimeJesus commented 2 years ago

New Changes

Fixes an issue when the user have a path but still can not mint:

Example

The group currency contract is verified so now we can debug a little bit easier the errors from this

tenderly tx: https://dashboard.tenderly.co/public/safe/safe-apps/simulator/4a9fdca4-17d1-4512-82e1-d51434c7b64a blockscout tx: https://blockscout.com/xdai/mainnet/tx/0x4936a430838a6488eaabd138c265086b0d8fd943662ec70c404214653b7116a2

Shisus (account safe from circles garden) is not a member of the group but has a trusting relationship with some members of the group.

mint-shisus-1