[Bug] Fixes Create Group Validation + Fee Information - Githubissues

CirclesUBI / circles-groups-safe-app

[DEPRECATED] Mint Circles group tokens using this Safe app

https://groups.circlesubi.dev/

1 stars 1 forks source link

[Bug] Fixes Create Group Validation + Fee Information #156

Closed LaimeJesus closed 2 years ago

LaimeJesus commented 2 years ago

related #142 #13

Description

This PR fixes some validations in the Create Group Form:

[UI] Placeholders: name, symbol, fee, treasury
[UI] Label: fee max allowed is 25.5
[DAPP] Validations:
- group name, symbol and treasury must be defined
- treasury is an address
- fee is a number between 0 and 25.5 (which is the max allowed to create a group)
[DAPP] formatNumber function to limit size of decimals in a number
[DAPP] some refactors to the Input component

How To Test

Create a Group
Set different values for the fee amount

create-group-with-new-fee-1 create-group-with-new-fee-2

TX: https://blockscout.com/xdai/mainnet/tx/0xc087d4ef3ff2cddbf102fa5e3b590d399bb2372043d51a8f3eda3691cf94dc2c

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
circles-groups-safe-app	✅ Ready (Inspect)	Visit Preview	Sep 2, 2022 at 6:26PM (UTC)