search

CirclesUBI / circles-groups-safe-app

[DEPRECATED] Mint Circles group tokens using this Safe app
https://groups.circlesubi.dev/
1 stars 1 forks source link

Fix/#169 & #170 filters users from both group members and non group members lists #179

Closed marcelorubini closed 2 years ago

marcelorubini commented 2 years ago

related #170 #169 also fixes NoResultsText behavior for GroupList

Description

This PR fixes user filter when adding new members or just filtering already group members. Adds specific no results messages for each case.

Requirements

To test all possible messages it's required to have a safeAddress which is already a group member (for users filter messages) and a non group member safeAddress for no group filter messages.

How to test it (different cases)

Manange Group

Group Members tab

Group has no members yet no-group-members

Search for a user that is already a group member group-member-filter

Search for a user that is not a group member not-a-group-member

Add Members tab

Search for a user that is not a group member yet not-a-group-member-yet

Search for a user that is already a Group Member already-a-group-member

Search for a non existent user nonexistentuser

GroupList

User does not belong to a group yet dont-belong-to-a-group

Search for Non Existent Group couldnt-find-a-group

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
circles-groups-safe-app ✅ Ready (Inspect) Visit Preview Aug 10, 2022 at 8:49PM (UTC)
marcelorubini commented 2 years ago

Solved comments, thanks a lot for the heads up! Let me know when you are available to discuss o re-think them :+1: