CirclesUBI / circles-groups-safe-app

[DEPRECATED] Mint Circles group tokens using this Safe app
https://groups.circlesubi.dev/
1 stars 1 forks source link

Search functionality UX when a user is already a member of a group #206

Closed InakyMaister closed 1 year ago

InakyMaister commented 1 year ago

Current behavior

Whenever a group admin attempts to search an already member using a combination of characters that only returns a sole user of the Circles ecosystem, the message displayed is said combination of search characters, and not the actual member added.

Steps to reproduce

Expected behavior

Whenever a user attempts to search for another user and the keywords offer a sole match, the message displayed should be that sole result/user/match, otherwise the impression is that a wrong user had been added to the group instead of the desired one.

See screenshot for clarity

Screen Shot 2022-08-17 at 14.52.05.png

LaimeJesus commented 1 year ago

How to test

Go to staging: https://staging-circles-groups-safe-app.vercel.app/ Go to gnosis: https://gnosis-safe.io/app Add app as a custom app Go to manage members (with a group owner account) In add members tab, search an already member and some text that has a minor difference

https://user-images.githubusercontent.com/13955827/185928098-3b568fd2-f8a0-4c49-8c5e-b17db8541062.mp4