search

CirclesUBI / circles-groups-safe-app

[DEPRECATED] Mint Circles group tokens using this Safe app
https://groups.circlesubi.dev/
1 stars 1 forks source link

Bug/#227 incorrect tx hash link #230

Closed LaimeJesus closed 1 year ago

LaimeJesus commented 1 year ago

Description

This PR fixes the error when using the useSafeTransaction hook to execute transaction displays the sucess modal with an invalid url link. The previous implementation has this bug because it didn't have a waiting function before each call to the status of the tx. The current implementation solves this issue by waiting an amount of time before retrying it.

How To Test

Go to some of the following pages: (mint group, update group who can mint configuration, add/remove many members) Execute a transaction See success modal should redirect to valid transaction

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
circles-groups-safe-app ✅ Ready (Inspect) Visit Preview Aug 30, 2022 at 2:14PM (UTC)
LaimeJesus commented 1 year ago

New Changes

There seems to be an issue with the gnosis safe sdk library where sometimes when looking for the transaction status details it throws an invalid state. In that case the success modal link will send the user to the gnosis safe transaction history instead of the gnosis explorer.