search

CirclesUBI / circles-myxogastria

Webapp and mobile client for Circles
https://circles.garden
GNU Affero General Public License v3.0
37 stars 21 forks source link

The Shared Wallets creation process is fragile and if stopped leaves accounts in invalid state #244

Open llunaCreixent opened 3 years ago

llunaCreixent commented 3 years ago

We've found issues with the Shared Wallets creation process. When the process is stopped (user refreshes/closes the app), the Shared Wallet remains in an invalid state.

There are 2 possible solutions for this.

1. Get rid of the relayer

This solution involves refactoring the core, introducing the Multisend contract to do batch tx, and adding recovery logic. This is the ideal solution and long term goal.

2. Introduce a recovery process to the current implementation

If we introduce a recovery process, we'll need to identify the steps required for deploying an organization, and find out when it can go wrong and what can be done to recover. The solution following this strategy would involve:

triaslucia commented 2 years ago

WiP

Design Meterial ( on purple) https://www.figma.com/file/ZTqF54s6CSHTwAxp0U0JjQ/Circles-myxogastria?node-id=3909%3A6290

Adding recovering checkpoints: (my suggestions are) 

1_ Fund your organization 
 2_Make profile (Always come back to User Name)

UX solution: When people start again the process of creating a SW, they will be told that they have an unfinished SW. And would be givingthe change to pick up on it.

Question @llunaCreixent : Is it possible to eliminate the "halfway accounts" if people do not choose to pick up on them?

llunaCreixent commented 2 years ago

Question @llunaCreixent : Is it possible to eliminate the "halfway accounts" if people do not choose to pick up on them?

Hi @triaslucia, it is possible to remove the half-way accounts by changing the ownership of the accounts from you to the ZERO address (who is not controlled by anyone)

triaslucia commented 1 year ago

We will split this into two tasks. One short term "do not refresh msg" and long term continue with the recovering of the recovery process.

See https://github.com/CirclesUBI/circles-myxogastria/issues/494