search

CirclesUBI / circles-myxogastria

Webapp and mobile client for Circles
https://circles.garden
GNU Affero General Public License v3.0
37 stars 21 forks source link

Disable notification spam during not allowing camera access in browser #690

Closed mikozet closed 1 year ago

louilinn commented 1 year ago

Hi @mikozet, Can you describe what was the problem and what is the new behaviour? Does it still through the error but not in a spammy way?

louilinn commented 1 year ago

Hi @mikozet, Can you describe what was the problem and what is the new behaviour? Does it still through the error but not in a spammy way?

mikozet commented 1 year ago

Hi @mikozet, Can you describe what was the problem and what is the new behaviour? Does it still through the error but not in a spammy way?

Hey, sure. Problem was that when there was an error onError function got triggered which displayed notification. But that onError function also caused hook to rerun and throwing an onError again - creating an endless loop

mikozet commented 1 year ago

Yes, the error is now trigerred but not in a spammy way