search

CirclesUBI / circles-website

Home of Circles UBI
https://joincircles.net
GNU Affero General Public License v3.0
8 stars 8 forks source link

Focus border looks a little strange #12

Closed adzialocha closed 4 years ago

adzialocha commented 4 years ago

photo_2020-08-19_14-07-20

Sorry for the bad picture, I couldn't take a screenshot as the border would disappear then :-)

eminx commented 4 years ago

Grommet has this focus thing to indicate any link/button clicked, which I think makes sense to have..? But styling-wise this is just default with the brand color of circles (some purple) and it can easily be changed.

What do you find strange in this exactly @adzialocha ? How would you like it to be rather? :) Do you think the other focus styles for links are also strange?

adzialocha commented 4 years ago

The focus thing is great of course, I just wonder if there is something which is closer to the page design. My suggestion would be:

  1. Use a less strong color (the purple is only used for the footer and call to action buttons)
  2. Give more padding to the elements as the border really sits right at the edge which is a pattern I can't see anywhere else on the website
  3. Make the borders more round? Again, this would suit the rest of the page better

... for the call-to-action button its alright (as it is purple and actually the border is round), for the social media icons its a little strange, but maybe there it can be the icon being colored black / purple and no border?

adzialocha commented 4 years ago

Also looking at the hamburger menu focus state I wonder if we can do something there as well, maybe again no border (similar to the social media icons mentioned above) but rather a different fill color?

eminx commented 4 years ago

Yes I agree, it could/should be different/better...