search

CirclesUBI / circles-website

Home of Circles UBI
https://joincircles.net
GNU Affero General Public License v3.0
8 stars 8 forks source link

Businesses Page Release and quite a few improvements #57

Closed eminx closed 3 years ago

eminx commented 3 years ago

So with this PR, we are addressing quite a few issues.

Closes #48 Closes #49 Closes #50 Closes #53 Closes #55

The preview page can be seen here: https://preview.joincircles.net/businesses

louilinn commented 3 years ago

Another thing: the donation page is still sopped to be at joincircles.net/en/donate or not reachable? It is still there if you have the link

eminx commented 3 years ago

I didn't see the translations working, though.

Which translations do you mean? For the business page, there are no translations available and I actually had asked for it, but they said we'll release only in English...

@llunaCreixent

Thanks for the review also!

eminx commented 3 years ago

Another thing: the donation page is still sopped to be at joincircles.net/en/donate or not reachable? It is still there if you have the link

The translation tool we're using doesn't really work with /en since english is default. But other langs do work. So for english, joincircles.net/donate

@louilinn

Thanks!

eminx commented 3 years ago

The spacing on the business page seems a little off from the design The circles vs bitcoin section especially. The network image goes outside the white circle on mobile view and the circle becomes very large in website fullscreen. Also a long space after this section.

This I'm aware and have consulted to Lucia about prior to making it. There's not much to do with the spacing if we want to pursue certain design effects in all screens, such as the perfect circle cut on the sides, behind the vs-bitcoin section...

About:

The network image goes outside the white circle on mobile view

Could you please upload a screenshot and tell me what device/os/browser you're using @louilinn ? I checked it on different devices and it was fine on my end but I perhaps missed something.. Thanks!

louilinn commented 3 years ago

Could you please upload a screenshot and tell me what device/os/browser you're using @louilinn ? I checked it on different devices and it was fine on my end but I perhaps missed something.. Thanks!

I think it is ok probaly. It was using dev tools in firefox and now i can't reproduce it so it's probably nothing..

Regarding the donation page I was refering to whether the donation page should still be up on https://joincircles.net/donate or if that route should no longer exist

eminx commented 3 years ago

I think it is ok probaly. It was using dev tools in firefox and now i can't reproduce it so it's probably nothing..

Aha OK then it's normal. You probably manually changed the size of the window right? Then it messes up but on the first page load, it checks the screen width and height of the container and accordingly locates svg background image behind. But when user changes the width of the browser, this doesn't re-run...

Regarding the donation page I was refering to whether the donation page should still be up on https://joincircles.net/donate or if that route should no longer exist

Yes, the donation page will remain, we just removed the main menu link to the page...

@louilinn

eminx commented 3 years ago

@louilinn & @llunaCreixent feel free to approve the review if/when you don't have any other concerns... :)

llunaCreixent commented 3 years ago

I didn't see the translations working, though.

Which translations do you mean? For the business page, there are no translations available and I actually had asked for it, but they said we'll release only in English...

@llunaCreixent

Thanks for the review also!

Understood! In that case, the translation PR (https://github.com/CirclesUBI/circles-website/pull/47) is not really closed by this PR, right?

eminx commented 3 years ago

In that case, the translation PR (#47) is not really closed by this PR, right?

Oh that's true! I mixed up the issues... It was #50 instead of #47

Corrected now! Thanks! @llunaCreixent

eminx commented 3 years ago

I just made some updates so need an approving review again pls 🙏

@houndbee @louilinn @llunaCreixent