CirclesUBI / infrastructure-provisioning

Infrastructure and Services for Circles
GNU Affero General Public License v3.0
5 stars 2 forks source link

feature/rds #15

Closed ana0 closed 5 years ago

ana0 commented 5 years ago

Addressed PR comments, except for deletion_protection .. looks like it was added to terraform only really recently (it's not in my version yet, for example) .. https://github.com/terraform-providers/terraform-provider-aws/issues/6008

Do we all want to upgrade?

d-xo commented 5 years ago

I'm fine with requiring the latest version of terraform.

edzillion commented 5 years ago

Problems applying this due to problems with CIDR block allocation.

Following this article: https://medium.com/@yaofei/aws-cidr-using-cloudformation-and-terraform-4f10bd86dbca