Add Clap to CLI - Githubissues

CirclesUBI / pathfinder2

MIT License

14 stars 9 forks source link

Add Clap to CLI #36

Open Gers2017 opened 1 year ago

Gers2017 commented 1 year ago

Hi everyone, I've made some changes that I hope will improve the CLI experience. I'm open to feedback or suggestions.

Add clap to parse the command line arguments
- It adds clap to the root directory since the CLI is under the bin directory.
- If this is an issue, then I could move the CLI into it's own workspace and consume the crate as a library.

I've tested the CLI and I haven't encountered any problems. However I'd like to hear your feedback on the argument descriptions. If necessary I'd be happy to change it.

louilinn commented 1 year ago

@Gers2017 are you yourself using the CLI? Sorry for taking so long to respond, currently we don't have a repo maintainer

Gers2017 commented 1 year ago

@louilinn Yes, I used the cli for some tests. Since this isn't a critical feature, feel free to close the pull request.

louilinn commented 1 year ago

Thanks for your reply! We very much appreciate your contribution. However we have a pending update in which the CLI was not prioritized to be maintained an therefore we might close this PR. If you are still using the CLI let us know and we can take it into consideration in our development work

llunaCreixent commented 1 year ago

I will test your PR because we actually need the CLI for our staging environment :)

benjaminbollen commented 1 year ago

Hey @Gers2017 thanks for your PR,

I recently joined as new maintainer of the pathfinder and related code bases and I had a quick look already to your PR, it looks great.

As it has been sitting here for a while, I'm sure you have moved on since, but wanted to thank you nonetheless. I added it to the board and will come back to it proper.

thanks already, Ben-