search

CirclonGroup / angular-tree-component

A simple yet powerful tree component for Angular (>=2)
https://angular2-tree.readme.io/docs
MIT License
1.1k stars 494 forks source link

Angular 7 support #689

Closed Maximaximum closed 5 years ago

Maximaximum commented 6 years ago

The docs say that this library only support Angular version up to v6. Is there going to be a new version with angular 7 support?

adamkleingit commented 5 years ago

Updated docs

azulay7 commented 5 years ago

@adamkleingit not working after ng-update to angular 7.0.4

adamkleingit commented 5 years ago

@azulay7 sorry, you are right, my tests were bad. Do you want to make a PR to fix it?

Kasilingam1230 commented 5 years ago

I too facing the same issue, if anyone fix it then it will be very helpful for me. Need a quick attention please.

azulay7 commented 5 years ago

@adamkliengit thank you for your answer. but Im just a user. I dont know the code enough to make PR.

adamkleingit commented 5 years ago

@azulay7 every user is a potential contributor in open source. If anyone wants to take this one it will be great

Melmoth-the-Wanderer commented 5 years ago

Works fine for me with angular 7.1.0 Is there anything in particular that does not work or throws an error? @azulay7 could you update ng to 7.1.0 and see if the problem persist?

adamkleingit commented 5 years ago

I'm closing this, if there is a more specific error please update

ramuda commented 5 years ago

currently using angular7 and angular tree component 8.2.0 If I push a treenode in existing tree and try calling update. It hangs on loading message.

adamkleingit commented 5 years ago

Can you reproduce in Stackblitz: https://stackblitz.com/edit/angular-wxansn