search

CirclonGroup / angular-tree-component

A simple yet powerful tree component for Angular (>=2)
https://angular2-tree.readme.io/docs
MIT License
1.1k stars 492 forks source link

Angular 9 update #806

Closed zainniazi closed 4 years ago

zainniazi commented 4 years ago
adamkleingit commented 4 years ago

Hi @zainniazi thanks for the PR. Can you say what is the static forRoot(): ModuleWithProviders<TreeModule> { needed for? Was there a warning/error, or it's just for better typings? Thanks BTW, there's another PR open for Angular 9: https://github.com/500tech/angular-tree-component/pull/815 We need to merge the best of both somehow

slavabogov commented 4 years ago

@adamkleingit Regarding ModuleWithProviders<TreeModule>: https://angular.io/guide/migration-module-with-providers

Libraries should add the generic type to any usages of the ModuleWithProviders type.

zainniazi commented 4 years ago

@adamkleingit Could you please help us update it to Angular 9 ?

mistic100 commented 4 years ago

@adamkleingit the other PR aims to changed how the lib is builded to respect Angular Package Format, it is not mandatory for Angular 9 compatibility.

This PR on the other hand is the strict minimum to make it working. It would be really helpful if you could reviewe and publish it.

edit: well I encountered the error on ModuleWithProviders twice in a row and now it never complains... didn't change a thing. This Ivy transpiler is very inconsistent