search

CirclonGroup / angular-tree-component

A simple yet powerful tree component for Angular (>=2)
https://angular2-tree.readme.io/docs
MIT License
1.1k stars 492 forks source link

Replacing lodash with lodash-es #807

Closed castevinz closed 4 years ago

castevinz commented 4 years ago

This PR allows to load lodash-es needed functions instead of complete lodash library.

castevinz commented 4 years ago

Hi @adamkleingit, What do you think about this PR ? lodash-es is "tree-shakeable" compared to lodash, even if full bundle size is bigger...

KeithGillette commented 4 years ago

We evaluated replacing lodash with lodash-es in our project, but based on these benchmarks, instead just blacklisted top-level imports from lodash. We did not do our own comparison, but for projects using small numbers of lodash functions, that apparently produces the smallest bundle sizes.

vcastelain commented 4 years ago

Thanks @KeithGillette for this benckmarks explanation... You can consider my PR useless or deprecated. I'll update my application to use Lodash by importing specifics methods instead of using lodash-es. Regards.

vcastelain commented 4 years ago

And sorry, I'm connected with my professional account, but it's me... castevinz = vcastelain ;)

tobiasengelhardt commented 4 years ago

Thanks for the PR @castevinz Closing this because we did this during the restructuring of the project.