Cosmetic changes - Githubissues

joseAndresGomezTovar commented 3 years ago

error NG8001, error NG8002, error TS2339 ...

PR Checklist

Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/CirclonGroup/angular-tree-component/blob/master/CONTRIBUTING.md#commit-message-guidelines
[ ] Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

tobiasengelhardt commented 3 years ago

Changing the imports from angular-tree-component to @circlon/angular-tree-component in the example app does not work. The tree component is not a dependency, so it's not inside the node_modules. The concept is to build the tree component and use the build version in the dist folder to run/test/develop the example and doc apps against. The reference works because the path to the dist folder is declared in the tsconfig.base.json. To make this change you have to change the tsconfig.base.json path to the dist folder to include the @circlon.