CirclonGroup / angular-tree-component

A simple yet powerful tree component for Angular (>=2)
https://angular2-tree.readme.io/docs
MIT License
1.1k stars 492 forks source link

style(component, directive, model): add types to whole project #885

Closed Amit775 closed 3 years ago

Amit775 commented 3 years ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[V] Code style update (formatting, local variables) - add types
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Some of the functions and models have type any. As a developer who used this awesome library I found that inconvenient.

Closes #

What is the new behavior?

Adding types to each method, model, variable etc. so a developer who use this library or contribute to this library have better intelisense and develop experience.

Does this PR introduce a breaking change?

no, for my knowledge

[ ] Yes
[V] No

Other information