feat: upgrade to Angular 18

bobbyg603 commented 2 years ago

PR Checklist

Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/CirclonGroup/angular-tree-component/blob/master/CONTRIBUTING.md#commit-message-guidelines
[x] Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #915

What is the new behavior?

Adds support for Angular 13 and builds library as 'partial' Ivy

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

Add eslint
Add core-js
Enable Ivy
Enable Aot
Fix polyfills
Fix lint errors
Fix template compilation errors
Fix example-app build
Fix docs-app build
Fix cyclical component references (https://github.com/angular/angular/issues/43227#issuecomment-904173738)

BREAKING CHANGE: Library is now built with 'partial' Ivy

bobbyg603 commented 1 year ago

@jodaka can you please merge this change? We would like to deprecate our fork. Thanks!

jodaka commented 1 year ago

I wish I could! I'm just a casual user of angular-tree-component and would love to see this PR merged. No idea why I had enough rights to review/approve your PR but I certainly don't have rights to merge it.

bobbyg603 commented 1 year ago

I wish I could! I'm just a casual user of angular-tree-component and would love to see this PR merged. No idea why I had enough rights to review/approve your PR but I certainly don't have rights to merge it.

ha! dang you could've fooled me 🙂. really disappointing to see libraries get abandoned by their maintainers.

ikruglik commented 1 year ago

I wish I could! I'm just a casual user of angular-tree-component and would love to see this PR merged. No idea why I had enough rights to review/approve your PR but I certainly don't have rights to merge it.

ha! dang you could've fooled me 🙂. really disappointing to see libraries get abandoned by their maintainers.

@bobbyg603 , @jodaka have you a forked version of the lib yet with the Angular 13+ supported?

bobbyg603 commented 1 year ago

@ikruglik yes, our forked version that targets Angular 13 can be found on npm

npm i @bugsplat/angular-tree-component

https://github.com/BugSplat-Git/angular-tree-component/blob/release/projects/angular-tree-component/package.json

bobbyg603 commented 1 month ago

hi @tobiasengelhardt, I've updated this project to use Angular 18. It's been 3 years since the last commit, perhaps you might let us take over the project?

tobiasengelhardt commented 1 month ago

@bobbyg603 I wish I could, but I have no rights to merge, push or change anything in this project.

CirclonGroup / angular-tree-component