search

CircuitLord / ReactiveMusic

GNU General Public License v3.0
3 stars 3 forks source link

Crash while launching #15

Closed Felisinnn closed 1 month ago

Felisinnn commented 2 months ago

1.20.1 fabric

Crash report: crash-2024-07-28_02.59.22-client.txt

Log: https://mclo.gs/YiGQd1z

CircuitLord commented 2 months ago

I've seen this crash happen a few times although I'm unclear on what's causing it exactly, can you verify you have a default audio device set and it's playing audio fine without Reactive Music in there?

Felisinnn commented 2 months ago

Thank you for the quick response! I was just testing some other mods before and sound was alright. After removing the mod the game booted up normally

CircuitLord commented 2 months ago

Gotcha alright, will take a look at it!

micahhanevich commented 2 months ago

Hey just wanted to add I'm also experiencing this issue. It works fine in some other personal modpacks I've made, but I think it may have something to do with Create. I'll play around with it and get back to this thread on it little edit: this is important to me because I can't play without this mod anymore lol

micahhanevich commented 2 months ago

Got it! The issue is with Ad Astra. If Ad Astra is installed alongside Reactive Music it crashes with this exact error. The only thing I can see on Ad Astra's end is a mixin to prevent the portal sound from playing when flying to other planets; don't know if seeing how they're doing that may help but here it is either way.

GeekyBakerBen commented 2 months ago

Seconded - I'm also getting this same crash issue with both Reactive Music and Ad Astra installed. RM used to work fine on my previous modpack which didn't feature Ad Astra.

AgentK20 commented 2 months ago

Ditto, also seeing this on my pack with Ad Astra

AgentK20 commented 2 months ago

Quickly glanced through your source: It's because you're overwriting the actual AdvancedPlayer class, while Ad Astra imports the upstream javazoom.jlayer library. Due to mod loading order it seems that your copy of the class gets stomped on, then causing a catastrophic NoSuchFieldError when your code finally runs, crashing the client.

I'd recommend either using a mixin-style modification of jlayer, or fork their library and rename the class paths to be unique. Overwriting the classes as you're doing is an easy way to have unexpected collisions with any other mod that happens to depend on the same library that you've modded.

CircuitLord commented 1 month ago

Gotcha thank you for looking into that

I don't really know anything about MC modding so I probably wouldn't have figured that out 😅

I'll try to fix that in the next update

CircuitLord commented 1 month ago

this is now fixed in https://github.com/CircuitLord/ReactiveMusic/commit/f6d02af28fa6617f0ce6e5cce4f32b4d17a932c6

thanks for the pointer @AgentK20!