CircuitVerse / Blog

Blog for updates from circuitverse
https://blog.circuitverse.org
5 stars 53 forks source link

Fix #130: contact us form is accepting empty feedbacks . #208

Closed subhamkumarr closed 8 months ago

subhamkumarr commented 8 months ago

Issue link: https://github.com/CircuitVerse/Blog/issues/130

Description:

The contact form was used to submit even when no inputs were entered. After making some changes, it now requires input before allowing submission

Snapshot

Before:

https://www.loom.com/share/4eb68bd9937a4443858c6f5ab41bdde9?sid=9c67844f-caf7-48fa-9bd4-dc4c3d5c159f

After:

https://www.loom.com/share/1265b4c8f19549a09b6d7777b9398ea3?sid=7c158744-d62d-4f69-9bff-9625421bd929

subhamkumarr commented 8 months ago

@tanmoysrt Sir, could you please review this PR

tachyons commented 8 months ago

Please do not make changes on submodule. Any changes on theme need to be done at the upstream repository

subhamkumarr commented 8 months ago

@tachyons, then how can I fix this issue? To solve this problem, I need to make changes in themes/layouts/contact/list.html. If there is another way to resolve this, please let me know. I need to fix this issue.

tachyons commented 8 months ago

You can make the changes to the upstream theme

subhamkumarr commented 8 months ago

@tachyons, where can I get the upstream theme in the blog repository?

subhamkumarr commented 8 months ago

@tachyons image are you talking about this? I need to commit in this upstream?