CircuitVerse / CircuitVerse-Presentation-Embed

MIT License
9 stars 6 forks source link

Browser Action : Link in popup does not redirect on click #22

Closed Shivansh2407 closed 2 years ago

Shivansh2407 commented 3 years ago

The Link in the Popup, when the Circuitverse Chrome Extension is clicked, does not performs any action. We need to Open in new tab by right clicking the link in order to view the Documentation.

Screenshot :

image

DevanshD3 commented 3 years ago

Is anyone working on this issue ? @Shivansh2407

Shivansh2407 commented 3 years ago

Go ahead @DevanshD3 and make a PR👍

ShreyaPrasad1209 commented 3 years ago

@Shivansh2407 @satu0king can we add this to good first issues?

Shivansh2407 commented 3 years ago

Sure! @satu0king please add a good-first-issue label here. Thanks :+1:

Jayita10 commented 3 years ago

@Shivansh2407 can I work on this issue?

ShreyaPrasad1209 commented 3 years ago

@Jayita10 sure

Jayita10 commented 3 years ago

The link should be redirected to here- https://docs.circuitverse.org/#/embedding_circuits?id=embedding-in-google-slides right?

Shivansh2407 commented 3 years ago

Yes @Jayita10 👍🏻

Jayita10 commented 3 years ago

I have checked Chrome Extension/views/browser_action.html and the link pasted there is exactly same, I think the issue is solved. Please correct me if I miss something

The link should be redirected to here- https://docs.circuitverse.org/#/embedding_circuits?id=embedding-in-google-slides right?

Shivansh2407 commented 3 years ago

Hey @Jayita10, are you able to view the CV Docs page on clicking the link? Because recently when I checked, I was not redirected to the Docs page, instead on clicking the link, nothing happened. If it's working on your end, do let us know.

Jayita10 commented 3 years ago

No it is not redirecting How should I approach for this problem?

Nonna-source commented 2 years ago

I would love to try my hand at this issue.

Palaksharma23 commented 2 years ago

I would love to work on this issue , can i take this up ?