CircuitVerse / CircuitVerse

CircuitVerse Primary Code Base
https://circuitverse.org
MIT License
869 stars 1.36k forks source link

Boolean Logic Table Output expression overflow #4526

Open Malavi1 opened 10 months ago

Malavi1 commented 10 months ago

Is there an existing issue for this?

Describe the bug

After entering the boolean expression to generate a combinational circuit if the output expression is large it is

Screenshot from 2024-01-06 17-50-08

Steps To Reproduce

Simulator->Tools->Combinational Analysis->Enter boolean expression with min. 4 variable

Expected Behavior

For this, I have 2 solutions

Moreover As shown below the height won't exceed more than this because we are not permitting the user to enter more than 8 variables expression

Screenshot from 2024-01-06 18-33-20

Screenshots

No response

Device Information [optional]

- OS:
- Browser:
- version:

Additional context

No response

Are you working on this issue?

Yes

tanmoysrt commented 10 months ago

Issue verified. @Malavi1 you can work on it.

Malavi1 commented 10 months ago

I just want to implement the second solution?! WDT

tanmoysrt commented 10 months ago

I just want to implement the second solution?! WDT

ig if the expression become large, the height will increase too much and it will be tough to read. Maybe scrollbar is better in this case.

WDYT @Prerna-0202 @Arnabdaz ?

Arnabdaz commented 10 months ago

both the points are valid i guess we can add a full-screen mode to view the full table or maybe open a new tab with the html of the table only on it.

but for normal modal we can keep using overflow making sure the table is correctly aligned with the variables at top.

wdyt @tanmoysrt @Malavi1

tanmoysrt commented 10 months ago

both the points are valid i guess we can add a full-screen mode to view the full table or maybe open a new tab with the html of the table only on it.

but for normal modal we can keep using overflow making sure the table is correctly aligned with the variables at top.

wdyt @tanmoysrt @Malavi1

yeah that will be better

in full-screen mode , we can open a new tab and show table wtithout overflow (by adjusting the height of header if required) and in normal view just overflow.

Malavi1 commented 10 months ago

Full screen mode not necessary ig bcoz by default we are not letting the user to create output expression with more than 8 variable as show in the above.

In the worst case the above showed height is the max height.

Arnabdaz commented 10 months ago

still its not future proof as in future we may support >8 variables ... lets use scrolling & fullscreen mode ... you can re-use the code used for printing the table.

Malavi1 commented 10 months ago

Yep, it's also true. Will implement both

Malavi1 commented 10 months ago

@Arnabdaz @tanmoysrt We can also implement this without scrolling and fullscreen, because irrespective of the mode we can only manipulate the output header cell but not the output result cells

Printing table windows also has the same result as this

Screenshot from 2024-01-06 21-14-07 Screenshot from 2024-01-06 21-14-23

Malavi1 commented 9 months ago

@Arnabdaz @tanmoysrt

Here is another solution where I introduced a button called Expand table

Screencast from 01-07-2024 10:43:18 AM.webm

Malavi1 commented 9 months ago

Can I get any input regarding the issue??