CircuitVerse / Interactive-Book

Interactive Online Book on Digital Logic Design
http://learn.circuitverse.org/
131 stars 195 forks source link

Correction in Interactive-gates page #473

Open harshitaaaaaa opened 3 years ago

harshitaaaaaa commented 3 years ago

The wires of circuit are not visible in the dark mode.

Screenshot from 2020-10-07 00-52-20

Here, Under the section: Two way light switch and security light, wires are clearly visible.

Screenshot from 2020-10-07 00-52-27

But as we switch to dark mode, the wires are not visible properly because the color of wires is overlapping with the color of the background.

anushri20 commented 3 years ago

Can I work on this?

YashKumarVerma commented 3 years ago

yes

anushri20 commented 3 years ago

Thanks!

Shivansh2407 commented 3 years ago

Hey @anushri20 , glad to see your enthusiasm to contribute to the Book, Currently the Codebase is undergoing a lot of transformations, it is better if you can fix the issues recently opened for the GSOD 2020 branch #475 , #476 . We will merge the PRs currently only for the GSOD 2020 branch . Looking forward to your PRs.

anushri20 commented 3 years ago

Okay, Thank you for letting me know @Shivansh2407

pavanjoshi914 commented 3 years ago

@Shivansh2407 in new structure of book( gsod branch) it is in http://localhost:4000/docs/comb-ssi/logic-gates.html i was thinking of rising a new issue for it. 2021-03-14_07-13 wire after gate needs to be white i would like to fix it. also the embed area for logic gate is dark which is hard to find in dark mode shall we try to change color of it too?

png for input is this 2021-03-14_07-26 png for output is this 2021-03-14_07-24 we need png for output in sync with png for input any suggestion where i can create new png also gate images for xor and xnor must be in sync (both in square) , green border is looking good for drop 2021-03-14_07-33

also in dark mode i am unable to see truth tables loaded 2021-03-14_07-34 shall I raise new issue @Shivansh2407 and start working on it

manjotsidhu commented 3 years ago

@pavanjoshi914 you can work on it and since GSoD2020 is merged, you can directly work on master branch.

Palaksharma23 commented 2 years ago

can I take up this issue ?

pavanjoshi914 commented 2 years ago

you can take this @Palaksharma23

Palaksharma23 commented 2 years ago

@pavanjoshi914 thank you sir

sharko7 commented 2 years ago

Can I work on this issue?