search

CircuitVerse / Interactive-Book

Interactive Online Book on Digital Logic Design
http://learn.circuitverse.org/
137 stars 196 forks source link

Simplifying top navigation #571

Open vedant-jain03 opened 3 years ago

vedant-jain03 commented 3 years ago

Describe the bug

  1. Removing Next and Previous buttons from the top and keep them just at bottoms.
  2. Changing the position of sidebar to fit in the topmost level navigation.
  3. Adding next_prev button to bottom of the Home
vedant-jain03 commented 3 years ago

@nitin10s

Palaksharma23 commented 2 years ago

@vedant-jain03 are you working on this issue ? if not, i would love to take up this issue .

vedant-jain03 commented 2 years ago

Yes

nitin10s commented 2 years ago

Lets just do 1 and 3 in a single PR for now

vedant-jain03 commented 2 years ago

Lets just do 1 and 3 in a single PR for now

Sure

manjotsidhu commented 2 years ago

@vedant-jain03 Can you state why you think we need to simplify interactive book on the 3 points you mentioned ?

vedant-jain03 commented 2 years ago

@vedant-jain03 Can you state why you think we need to simplify interactive book on the 3 points you mentioned ?

  1. Currently the next_prev button is placed twice on every page, so it will be space simplified if we place it once below every on every page.
  2. Currently there is a Sidebar button in header of every page but if we can place it in main navbar that will be more logical.
  3. Currently there is not content_footer in home page that resulting into no comment section , next_prev, more page suggestion etc.

@nitin10s suggest me to states these points in new issue: https://github.com/CircuitVerse/Interactive-Book/issues/565#issuecomment-939694040

If anything I need to change do let me know @manjotsidhu

manjotsidhu commented 2 years ago

In my opinion, I like the prev/next buttons both on top of the page as well as on bottom of the page. It gives me the feeling/vibe that this interactive "book" is really a book not any ordinary guide/blog/docs etc. Also, I will find it comfortable having buttons on top even though it's taking some space in the situations when the pages have a lot of content (Imagine reading a long page but you want to go next and previous, you will need to scroll to bottom). It makes it very easy to navigate specially if sidebar is collapsed.

This is my opinion but I want to open this discussion on this so that we can do what works best for Interactive Book. @nitin10s @Shivansh2407 @tachyons

nitin10s commented 2 years ago

@manjotsidhu I understand the use case that you mentioned and ideally, we should be monitoring the number of clicks to those buttons to understand their effectiveness. The idea, as Vedant mentioned was to simplify the page. If the user is navigating pages without reading, he can do so by the sidebar easily. In the situation you mentioned, if the user is reading a long page and he wants to go next/prev, even if the buttons are on top, he would have to "scroll to top" in this case which is similar to "scroll to bottom".

Let me know what you guys think..?

manjotsidhu commented 2 years ago

@manjotsidhu I understand the use case that you mentioned and ideally, we should be monitoring the number of clicks to those buttons to understand their effectiveness. The idea, as Vedant mentioned was to simplify the page. If the user is navigating pages without reading, he can do so by the sidebar easily. In the situation you mentioned, if the user is reading a long page and he wants to go next/prev, even if the buttons are on top, he would have to "scroll to top" in this case which is similar to "scroll to bottom".

Let me know what you guys think..?

For scroll to top we have a button to quickly scroll to top. We use just-the-docs theme and you can check this here and comparing to our use case that is primarily a book reading experience rather than reading docs, the only thing seperates from both is the ease of use by providing buttons both at top and bottom. These buttons are the only "extra" thing we have currently and I still think the site is minimal enough which doesn't needs to be simplified. I would take the trade off between ease of use and 50px of space.