Changed 2021 to 2022 - Githubissues

CircuitVerse / Interactive-Book

Interactive Online Book on Digital Logic Design

http://learn.circuitverse.org/

131 stars 195 forks source link

Changed 2021 to 2022 #608

Closed ZaidKhan2002 closed 2 years ago

ZaidKhan2002 commented 2 years ago

Fixes #606

Changes done:

[x] Changed 2021 to 2022 with JavaScript in all pages.

Screenshots

Preview Link(s):

✅️ By submitting this PR, I have verified the following

[x] Checked to see if a similar PR has already been opened 🤔️
[x] Reviewed the contributing guidelines 🔍️

netlify[bot] commented 2 years ago

✔️ Deploy Preview for vigilant-nightingale-2f57b2 ready!

🔨 Explore the source changes: e868f55f13e1dc56df88a55f40d40a5f46f6e706

🔍 Inspect the deploy log: https://app.netlify.com/sites/vigilant-nightingale-2f57b2/deploys/61e64ed70edb7600088d871a

😎 Browse the preview: https://deploy-preview-608--vigilant-nightingale-2f57b2.netlify.app

ZaidKhan2002 commented 2 years ago

I have one doubt. Like I made changes in many files but here there is only one file changed. Is this ok?

Palaksharma23 commented 2 years ago

@ZaidKhan2002 please add all the changed files in your commit :)

ZaidKhan2002 commented 2 years ago

@ZaidKhan2002 please add all the changed files in your commit :)

After making changes I opened my gitpod after timeout and then installed the bundle and jekyll serve all of the changes that I had made got vanished and also tried again same thing happened

ZaidKhan2002 commented 2 years ago

Also 2nd time after making changes I saw git status it says up to date with my branch working tree clean. Am I going somewhere wrong ?

Palaksharma23 commented 2 years ago

Also 2nd time after making changes I saw git status it says up to date with my branch working tree clean. Am I going somewhere wrong ?

checkout to your branch "changedYear" and then make the necessary changes and commit them, make sure to commit only those files in which you have made changes :) Don't worry if it's your first pull request, everybody face one or two issues initially✌

ZaidKhan2002 commented 2 years ago

Also 2nd time after making changes I saw git status it says up to date with my branch working tree clean. Am I going somewhere wrong ?

checkout to your branch "changedYear" and then make the necessary changes and commit them, make sure to commit only those files in which you have made changes :) Don't worry if it's your first pull request, everybody face one or two issues initially✌

Thankyou @Palaksharma23. Actually the problem was in my code I was making changes in auto generated html files and was changing year with JavaScript but on slack I got to know that changes will disappear and make change in yml file so made another PR regarding that.