CircuitVerse / Interactive-Book

Interactive Online Book on Digital Logic Design
http://learn.circuitverse.org/
137 stars 195 forks source link

Added a feature to take notes using localstorage Fixes #609 #611

Open Palaksharma23 opened 2 years ago

Palaksharma23 commented 2 years ago

Fixes #609

Screenshots

Finally

image

✅️ By submitting this PR, I have verified the following

netlify[bot] commented 2 years ago

✔️ Deploy Preview for vigilant-nightingale-2f57b2 ready!

🔨 Explore the source changes: 162e9e43a3019252330d273fea0e47863c26dabd

🔍 Inspect the deploy log: https://app.netlify.com/sites/vigilant-nightingale-2f57b2/deploys/61fdfe7972521d0008bd3bd6

😎 Browse the preview: https://deploy-preview-611--vigilant-nightingale-2f57b2.netlify.app

Palaksharma23 commented 2 years ago

image I think if we can have the notes at the place where a user has selected a text that will be much helpful.

Like according to me the user end flow must be like this user select a text -> notes button visible -> notes pad inserted at the place where user has selected the text

yes sir @ayan-biswas0412 this is a great idea 💡 I will commit this asap just one query that when a user take notes by selecting the text where should that note be display at the end of the page or inline with the text or on the right side of the page

ayan-biswas0412 commented 2 years ago

image I think if we can have the notes at the place where a user has selected a text that will be much helpful. Like according to me the user end flow must be like this user select a text -> notes button visible -> notes pad inserted at the place where user has selected the text

yes sir @ayan-biswas0412 this is a great idea 💡 I will commit this asap just one query that when a user take notes by selecting the text where should that note be display at the end of the page or inline with the text or on the right side of the page

Actually what happens in google docs commenting system, that's same i was suggesting. Ref : Google Docs Comments