Closed ItsAdityaKSingh closed 2 years ago
@manjotsidhu flutter test --coverage is failing due to the use of MediaQuery as it could not find generic widgets.
Upon changing tests, still, the error was persistent, so I changed the height of the container and let the height of the image remain 300. With this, the issue is resolved, and no CI tests fail.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
lib/ui/views/authentication/login_view.dart | 2 | 3 | 66.67% | ||
lib/ui/views/authentication/signup_view.dart | 2 | 3 | 66.67% | ||
<!-- | Total: | 4 | 6 | 66.67% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
lib/ui/views/authentication/login_view.dart | 2 | 78.95% | ||
<!-- | Total: | 2 | --> |
Totals | |
---|---|
Change from base Build 1634714668: | -0.006% |
Covered Lines: | 3883 |
Relevant Lines: | 5371 |
@manjotsidhu Required changes done. You may merge it now!
Please don't mix other issues in a single PR. There is no limit to the number of PRs you can submit.
Please don't mix other issues in a single PR. There is no limit to the number of PRs you can submit.
Ok, sure, let me clean this mess up! Sorry for the inconvenience!
fixes #186
Describe the changes you have made in this PR - Improved sizing of widgets to fit all on the same working screen. Also included sizer package for any future reference.
Screenshots of the changes (If any) -
Checked on different screen sizes!
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.