Closed Aditya-150 closed 2 years ago
@Aditya-150 Run the command "flutter format ." in the project's home directory. And commit the changes.
@Aditya-150 Run the command "flutter format ." in the project's home directory. And commit the changes.
Thanks @aman-singh7 for pointing out that. I just forgot to format the file. Hope this works .
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
lib/ui/components/cv_flat_button.dart | 2 | 4 | 50.0% | ||
<!-- | Total: | 2 | 4 | 50.0% | --> |
Totals | |
---|---|
Change from base Build 2898848819: | -0.02% |
Covered Lines: | 4017 |
Relevant Lines: | 6074 |
Hey, @aman-singh7 sorry for disturbing for you. But can you review it.. #240 #233
Thank you for your contributions @Aditya-150, Initial impressions of the code looks good. I will review and test it very soon.
@manjotsidhu The changes are working fine.
Fixes #233
Describe the changes you have made in this PR - There was a bug in package:mobile_app/ui/components/cv_flat_button.dart . The foregroundColor was set to grey by default. That's why the color of the button was not changing on state change.
Screenshots of the changes (If any) -
https://user-images.githubusercontent.com/78409764/188433775-eb043b0b-a228-4ce7-b971-16cc1dc84d3c.mp4
Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.