CircuitVerse / mobile-app

Mobile App for CircuitVerse
https://play.google.com/store/apps/details?id=org.circuitverse.mobile_app
MIT License
70 stars 93 forks source link

moved the theme changer slightly down #245

Closed anuragrao04 closed 1 year ago

anuragrao04 commented 1 year ago

Fixes #244

Changes made in this PR - The theme changer button has been moved slightly down inorder to avoid hitting the dynamic island on newer iPhone models

Screenshots of the changes - Refer the original issue for the before picture. After picture:

Screenshot 2022-11-10 at 7 51 56 PM
anuragrao04 commented 1 year ago

The changes are really small but this is my first PR to this repo and flutter in general!

manjotsidhu commented 1 year ago

@anuragrao04 Thanks for contributing, can you send a preview on Android with the above change ?

aman-singh7 commented 1 year ago

Hey @anuragrao04, Instead of hardcoding, could you implement it with SafeArea. Wrap the Drawer child with SaferArea and test it on the devices.

anuragrao04 commented 1 year ago

sure! I'll get it done as soon as possible