automatically create chips for email inputs

CircuitVerse / mobile-app

Mobile App for CircuitVerse

https://play.google.com/store/apps/details?id=org.circuitverse.mobile_app

MIT License

73 stars 94 forks source link

automatically create chips for email inputs #246

Closed danger-ahead closed 1 year ago

danger-ahead commented 1 year ago

Fixes #241

Describe the changes you have made in this PR --

[x] Added chips
[x] Emails get added to chips after pressing space
[x] Single email that has not yet been added to a chip by pressing space still works and an email gets sent.
[x] Combination of chips and a last email that has not yet been added to a chip works.

Screenshots of the changes (If any) - https://user-images.githubusercontent.com/55531939/201372810-468c79fd-8d3f-4149-8b2c-4a5f38bed91b.mp4

aman-singh7 commented 1 year ago

Thank you for your contributions @danger-ahead! We are using MVVM architecture + provider for state management. Please implement the changes in that fashion instead of setState.

danger-ahead commented 1 year ago

Thank you for your contributions @danger-ahead! We are using MVVM architecture + provider for state management. Please implement the changes in that fashion instead of setState.

I have little experience in using architecture. Can you please guide me on the changes required?

For now, I haven't changed the internal working or function calls, I have just updated how data is processed after being inputted by the user.

danger-ahead commented 1 year ago

Also I have called the setstate inside another statefulbuilder, to avoid unnecessary rerenders of the whole screen.