automatically create chips for email input - Githubissues

CircuitVerse / mobile-app

Mobile App for CircuitVerse

https://play.google.com/store/apps/details?id=org.circuitverse.mobile_app

MIT License

73 stars 94 forks source link

automatically create chips for email input #247

Closed danger-ahead closed 1 year ago

danger-ahead commented 1 year ago

Fixes #241

Describe the changes you have made in this PR --

[x] Added chips
[x] Emails get added to chips after pressing space
[x] Single email that has not yet been added to a chip by pressing space still works and an email gets sent.
[x] Combination of chips and a last email that has not yet been added to a chip works.

Screenshots of the changes (If any) - create_chips.webm

aman-singh7 commented 1 year ago

@manjotsidhu looks fine from my side. Any views?

manjotsidhu commented 1 year ago

I recently merged fixes for CI/CD, please resolve conflicts and we are good to merge it :)

danger-ahead commented 1 year ago

@manjotsidhu @aman-singh7 conflicts fixed!

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3661285818

8 of 26 (30.77%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 64.63%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
lib/ui/views/groups/group_details_view.dart	8	26	30.77%
<!--	Total:	8	26	30.77%	-->

Totals
Change from base Build 3659893300:	0.02%
Covered Lines:	4040
Relevant Lines:	6251

💛 - Coveralls