CircuitVerse / mobile-app

Mobile App for CircuitVerse
https://play.google.com/store/apps/details?id=org.circuitverse.mobile_app
MIT License
70 stars 93 forks source link

Updated state management of floating buttons in Interactive book #253

Closed tanmoysrt closed 1 year ago

tanmoysrt commented 1 year ago

Fixes #251

Describe the changes you have made in this PR - I have updated the state management from tradition setstate to GetX. At first sight, I have decie to go with Provider but later found that GetX is alreaday present as an dependency in the app. So used that andd optimized that. This fix solve which things

Screenshots of the changes (If any) -

A screen recording after updating

https://user-images.githubusercontent.com/57363826/211865395-4056b4af-ee5e-4382-ac2f-8a9031759c5c.mp4

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

tanmoysrt commented 1 year ago

@aman-singh7 kindly review this PR

aman-singh7 commented 1 year ago

@Tanmoy741127 Provider is used for state management in the app. So, for consistency implement using Provider instead of GetX.

tanmoysrt commented 1 year ago

@aman-singh7 Ok ! Then, i will make the changes using provider

tanmoysrt commented 1 year ago

@aman-singh7 I did not got time to fix the issue. will try to submit the prs by next weekend.

tanmoysrt commented 1 year ago

@Tanmoy741127 Provider is used for state management in the app. So, for consistency implement using Provider instead of GetX.

@aman-singh7 I have submitted new PR with changes with Provider #254 Kindly check